> On Jan. 2, 2013, 3:18 p.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1080 > > <http://git.reviewboard.kde.org/r/103555/diff/1/?file=44960#file44960line1080> > > > > I don't understand the if(). Why should the behavior differ depending > > on whether we have this url currently shown (itemsInUse) or in the cache > > (itemsCached), compared to when we don't know about this URL? > > > > The if() is wrongly written anyway: if it should be there, then it > > should be url.url(), not url.path(), since itemsInUse and itemsCached use > > URLs as keys. I should change that to QUrl in KF5. > > > > And in case you remove the if, then my old comment meant: in that case, > > we can simplify the code to remove the if (isDir), and simply do > > > > Q_FOREACH(const QString& dir, > > directoriesForCanonicalPath(url.directory())) { > > handleDirDirty(dir); > > } > > > > in all cases (file or directory). > > Because as you say, it's the parent that needs to be re-listed when the > > permissions of anything changes. > > > > > > Also, this changes misses a corresponding unittest in > > kdirlistertest.cpp.
Ahh... I see what you mean. I should have realized what I was doing is utterly unnecessary. I will make the change as you suggested and add a test case for this. In fact, I will add the unittest first to test for the failure. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review24439 ----------------------------------------------------------- On Dec. 29, 2012, 8:31 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103555/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2012, 8:31 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > If you open a directory that contains other directories in Konqueror or > Dolphin, change the permission of one of these directories from outside, say > the command line, and right click on the same directory to look at the > permission tab in the properties dialog, you will see that the permission > change has not been updated. This patch addresses that bug. > > > This addresses bug 173733. > http://bugs.kde.org/show_bug.cgi?id=173733 > > > Diffs > ----- > > kio/kio/kdirlister.cpp ec3d622 > > Diff: http://git.reviewboard.kde.org/r/103555/diff/ > > > Testing > ------- > > 1. In konsole, create a test directory within another test directory: > mkdir -p test/test1 > > 2. Open Dolphin or Konqueror and navigate to the top newly created directory, > i.e. test. > > 3. In konsole, cd into the first test directory: > cd test > > 4. In konsole, change the permission of 'test1' from konsole. For example, > chmod go-rx > > 5. In the open Dolphin or Konqueror, right click on "test1", select > properties and click on permission tab. > > 6. Validate whether or not the permission shown in the GUI matches what you > get in the command line. > > > Thanks, > > Dawit Alemayehu > >
