-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107970/
-----------------------------------------------------------
Review request for kde-workspace.
Description
-------
I've added support for sensor displays in KSysGuard to have row spans and
column spans.
Apart from adding rowSpan and columnSpan arguments to the method signatures,
I've also removed the internal list (WorkSheet::mDisplayList) used to contain
all the sensor displays. This list used to be used to derived the row and
column of the displays based on their index in the list. Since I now need to
maintain rowSpan and columnSpan information as well, I just removed the list
entirely and get all my data from mGridLayout. As a result, another change in
the method signatures is the replacement of the "index" parameter with "row"
and "column" parameters.
An extra advantage of doing it this way is that widgets don't shift around when
resizing the grid. Another advantage is that blank spaces between the widgets
are now possible. Not to mention, not maintaining the layout information
outside of the actual layout component (mGridLayout) seems a clearer design to
me.
This addresses bug 311925.
http://bugs.kde.org/show_bug.cgi?id=311925
Diffs
-----
ksysguard/gui/WorkSheet.h 9f4806d
ksysguard/gui/WorkSheet.cpp b20f077
Diff: http://git.reviewboard.kde.org/r/107970/diff/
Testing
-------
Works on 4.9.4
Screenshots
-----------
Example
http://git.reviewboard.kde.org/r/107970/s/936/
Thanks,
Arnav Singh
