> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote:
> > kdeui/util/kkeyserver_x11.cpp, line 358
> > <http://git.reviewboard.kde.org/r/105909/diff/1/?file=76478#file76478line358>
> >
> > I think this will break calculator key for other users. This change
> > also does not make sense, Key_Calculator is a better name for this key than
> > Key_Launch1. My guess is that the keyboard is sending the wrong keysym to
> > Xorg.
>
> Andreas Pakulat wrote:
> Calculator key is working just fine on my Microsoft Natural and was
> working also on a Cherry CyMotion Master Linux I had before. And yes
> Key_Launch1 is definetly wrong I'd say.
>
> Kai Uwe Broulik wrote:
> It does not work on my Microsoft Wireless Keyboard 800 or my Wired
> Keyboard 600. KDE just adds "Start (1)" as key and it does not work. So,
> Upstream issue?
>
> Lamarque Vieira Souza wrote:
> It is likely a problem with your keyboard sending wrong keysyms. You can
> change the keysym they send using xmodmap command.
No. No matter where i map the key (and xev reports that symbol correctly)
KKeySequenceWidget detects it wrongly as "Launch (1)" here (so i can confirm
the bug).
It's probably related to keyboard driver (ie. evdev) since this:
setxkbmap -layout de -model microsofccurve2k -option
terminate:ctrl_alt_bksp,ctrl:nocaps -variant deadgraveacute -rules xorg
-keycodes evdev
leading to:
xkb_keymap {
xkb_keycodes { include "xfree86+aliases(qwertz)" };
xkb_types { include "complete" };
xkb_compat { include "complete" };
xkb_symbols { include
"pc+de(deadgraveacute)+ctrl(nocaps)+terminate(ctrl_alt_bksp)" };
xkb_geometry { include "pc(pc104)" };
};
leaves the key undefined and KKeySequenceWidget will probably fetch the symbol
from the kbmap - thus mapping it anywhere has no effect here.
Nevertheless, this patch is certainly wrong and just manipulates a symptom of a
sublying bug and will thus most likely cause trouble on systems not affected by
that actual bug which should be fixed instead.
PS/OT:
it's btw. stunning how many MS keyboards seem in use - while except of the
logo, there's really nothing i could concern about mine =)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105909/#review17061
-----------------------------------------------------------
On Aug. 7, 2012, 12:13 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105909/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2012, 12:13 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> This little patch fixes the calculator key not working.
> It is actually the patch created by Leonardo in the bug report.
>
>
> This addresses bug 257900.
> http://bugs.kde.org/show_bug.cgi?id=257900
>
>
> Diffs
> -----
>
> kdeui/util/kkeyserver_x11.cpp 80a2af4
>
> Diff: http://git.reviewboard.kde.org/r/105909/diff/
>
>
> Testing
> -------
>
> Works.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
