> On May 13, 2012, 2:07 p.m., Maks Orlovich wrote: > > Any performance effect?
With sunspider, out of 10x10 runs with and without the patch, this turns out to be a small performance improvement. As I really couldn't believe it I reverted everything and tested again, but the results are the same. with this patch, after 10x10 runs AVG: 2790.5875ms without this patch, after 10x10 runs AVG: 2846.6625ms diff: 56.075ms So... at least for sunspider its a small performance improvement - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104906/#review13780 ----------------------------------------------------------- On May 10, 2012, 7:01 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104906/ > ----------------------------------------------------------- > > (Updated May 10, 2012, 7:01 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: Introduce & use leftFirst parameter in relation check, according to > Ecmascript 5.1r6. > > This fixes the access order for Greater-than and Less-than-or-equal Operator > > > NOTE: please ignore patch r1, it was the wrong patch, luckily normal View > Diff always points to the latest version :) > > > Diffs > ----- > > kjs/bytecode/codes.def bcd2e3a > kjs/operations.h f8a28c8 > kjs/operations.cpp d4c0066 > > Diff: http://git.reviewboard.kde.org/r/104906/diff/ > > > Testing > ------- > > ecma 11.8.2 tests > > > Thanks, > > Bernd Buschinski > >
