----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13436 -----------------------------------------------------------
Any re-review on this? - Mark Gaiser On May 2, 2012, 6:19 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104801/ > ----------------------------------------------------------- > > (Updated May 2, 2012, 6:19 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > So i was trying to fix this bug: https://bugs.kde.org/show_bug.cgi?id=181531 > That only asked for one more shortcut. That issue seems to be a little more > complicated than it looks. Till this point KActions could only have a > "Primary" and a "Alternate" shortcut. 2 in total which is - in some > situations - not enough. > > I fixed this by roughly restructuring nearly all of the KShortcut cpp file. > > I have 2 issues remaining: > 1. QList<QKeySequence> toList() const; > 2. KShortcut shortcut() const; > > If i enable those functions the compiler suddenly doesn't know which function > to use.. The old ones or the new ones. Some suggestions on how to fix it > would be welcome. > > > Diffs > ----- > > kdeui/actions/kaction.h d877554 > kdeui/actions/kaction.cpp 309cf82 > kdeui/shortcuts/kshortcut.h c720830 > kdeui/shortcuts/kshortcut.cpp e307ab0 > > Diff: http://git.reviewboard.kde.org/r/104801/diff/ > > > Testing > ------- > > I tested this by adding the missing bindings for Dolphin's back/forward and > it seems to be working just fine. I can use all available shortcuts. > > > Thanks, > > Mark Gaiser > >
