----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ -----------------------------------------------------------
(Updated April 29, 2012, 8:22 p.m.) Review request for kdelibs. Changes ------- Resolved issues raised. Description ------- The following patch fixes the following krazy2 warnings: - Use const references in Q_FOREACH statements where appropriate. - Normalize yet more signal/slot connections (missing from the first go round). - Use brackets instead of double-quotes for the 'config*' header files. - Fix the #ifdef statements in header files to reflect the header filename. I did this a long time ago, but never pushed upstream. As part of my spring clean up I want to push this local changes upstream. Any objections ? Diffs (updated) ----- kio/bookmarks/kbookmarkdialog.cc 713ceff kio/bookmarks/kbookmarkdombuilder.cc 8e0be3c kio/bookmarks/kbookmarkimporter.cc 08210f7 kio/bookmarks/kbookmarkmanager.cc d8a9cb7 kio/bookmarks/kbookmarkmenu.cc deb973b kio/bookmarks/konqbookmarkmenu.cc 4fc6be0 kio/kfile/kfilemetadataprovider.cpp 8caa0c2 kio/kfile/kfilemetadataprovider_p.h 09d924a kio/kfile/kfilemetadatareaderprocess.cpp 5103087 kio/kfile/kimagefilepreview.cpp 74ef8b7 kio/kio/chmodjob.cpp 85e0c2c kio/kio/job.h aeaffa2 kio/kio/job.cpp 5e18998 kio/kio/jobuidelegate.cpp 85679c2 kio/kio/kdesktopfileactions.cpp edf2e9c kio/kio/kfileitemactions.h 27ab4e3 kio/kio/kfileitemactions.cpp c79a434 kio/kio/kfilemetainfoitem.cpp 1cab458 kio/kio/ksambasharedata.cpp aebcb04 kio/kio/kurifilter.h 289b910 kio/kio/kurifilter.cpp 0144a2c kio/kio/renamedialog.cpp 11e55a9 kio/misc/kpac/proxyscout.cpp 0068ce7 kio/misc/kpac/script.cpp a595301 nepomuk/core/resourcedata.cpp d6b0121 Diff: http://git.reviewboard.kde.org/r/104785/diff/ Testing ------- Thanks, Dawit Alemayehu
