----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104179/ -----------------------------------------------------------
Review request for kdelibs and David Faure. Description ------- The attached patch adds several JavaScript policy and setting related enums and three convenience functions to KParts::HtmlSettingsInterface so that they can be shared by all browser engines (kwebkitpart and khtml) and the Konqueror html kcm. Currently these enums and convenience functions are duplicated in the two browser engines. The Konqueror html kcm simply uses the one from the khtml browser engine because it publicly exports those values. Unfortunately that means the html kcm has to directly link against the khtml engine resulting in it being loaded into memory when the Konqueror configuration dialog is launched even regardless of what browser engine is used as the default. This patch is the first step in removing that dependency so that khtml is not loaded when webkit is used as the default browser engine. Diffs ----- khtml/khtml_ext.cpp 3a1da4a kparts/htmlextension.h b91f203 kparts/htmlextension.cpp 761c42c Diff: http://git.reviewboard.kde.org/r/104179/diff/ Testing ------- Thanks, Dawit Alemayehu
