-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102691/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
This patch is the 4th in the serious of patches designed to resolve bugs and
missing functionality in KDE's proxy manager. The changes made with this patch
are as follows:
* Add code that resolves a request url's hostname before attempting to match
it against the no proxy for list so long as the
"ResolveHostNamesBeforeProxyCheck"
option is set.
* Allow "DIRECT" as a special keyword in the list of proxy server addresses
returned in slaveProtocol(const QString& protocol, QStringList& proxy).
* Change KProtocolManager::proxyFor to properly handle the changes in the
new
proxy management dialog (KDE 4.8) where the proxy server port, in the
manual proxy configuration mode, will be saved separated from the address
with
a white space.
* Move the code that accounts for SOCKS proxy from
KProtocolManager::proxyFor
to KProtocolManager::proxyForUrl where it belongs. The current
implementation
only works correctly under one circumstance while breaking the previous
behavior
of the function.
* Fix KProtocoManager::proxiesForUrl so that it accounts for the proxy
exception list.
* Update API documentation to reflect the changes above.
Diffs
-----
kio/kio/kprotocolmanager.h 11e43fe
kio/kio/kprotocolmanager.cpp 50ebb6e
Diff: http://git.reviewboard.kde.org/r/102691/diff
Testing
-------
Thanks,
Dawit
