----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102541/#review6300 -----------------------------------------------------------
lib/konq/kversioncontrolplugin.h <http://git.reviewboard.kde.org/r/102541/#comment5521> Typo. s/int/in/ lib/konq/kversioncontrolplugin.h <http://git.reviewboard.kde.org/r/102541/#comment5525> trailing whitespace lib/konq/kversioncontrolplugin2.h <http://git.reviewboard.kde.org/r/102541/#comment5523> This should be your copyright and 2011. lib/konq/kversioncontrolplugin2.h <http://git.reviewboard.kde.org/r/102541/#comment5522> We don't need KFileItem, KFileItemList here, but #include <QList> above. lib/konq/kversioncontrolplugin2.cpp <http://git.reviewboard.kde.org/r/102541/#comment5524> Same as above. - Sebastian On Sept. 6, 2011, 1:55 p.m., Vishesh Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102541/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2011, 1:55 p.m.) > > > Review request for Dolphin, KDE Base Apps, Peter Penz, and Sebastian Doerner. > > > Summary > ------- > > Added KVersionControlPlugin2 interface to let version control plugins be able > to show context menu anywhere not just in repositories. Will be useful to > implement commands like Clone(in Git, Hg) or Checkout(in SVN). Part of GSoC > project "Mercurial Plugin for Dolphin" http://goo.gl/6B2ly > > Not much changes. Just added one function right now. > > > Diffs > ----- > > lib/konq/CMakeLists.txt 651beff > lib/konq/kversioncontrolplugin.h e6cb2b4 > lib/konq/kversioncontrolplugin2.h PRE-CREATION > lib/konq/kversioncontrolplugin2.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102541/diff > > > Testing > ------- > > Yes. With my Mercurial plugin and modified Dolphin 1.7 source code, whose > patch I havent posted as Dolphin 2 is now coming up. > > > Thanks, > > Vishesh > >
