> On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/CMakeLists.txt, line 11 > > <http://git.reviewboard.kde.org/r/102267/diff/1/?file=31274#file31274line11> > > > > We usually do not use capitals in source code in kdelibs. (there are > > exceptions, but not in KIO). > > > > Also, it would be better if this were called ratecontroller.cpp, not > > speed controller.
acknowledged. > On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/speedController.h, line 29 > > <http://git.reviewboard.kde.org/r/102267/diff/1/?file=31277#file31277line29> > > > > Rename to RateController. acknowledged. > On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/speedController.h, line 37 > > <http://git.reviewboard.kde.org/r/102267/diff/1/?file=31277#file31277line37> > > > > Suggest renaming to nextReadBlockSize(). acknowledged. > On Aug. 10, 2011, 3:05 p.m., Thiago Macieira wrote: > > kioslave/ftp/speedController.h, line 45 > > <http://git.reviewboard.kde.org/r/102267/diff/1/?file=31277#file31277line45> > > > > Use QElapserTimer, not QTime. acknowledged. - Tushar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102267/#review5606 ----------------------------------------------------------- On Aug. 9, 2011, 7:16 p.m., Tushar Mehta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102267/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2011, 7:16 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > - This patch contains the basic code which will put the limit on download > speed of the ftp data transfer. > - It is looking for "speed-limit" meta-data for deciding how much speed > control is required. > - If this meta-data is not found, code will work as it was before and no > speed control related code will come into picture. > - This patch is the most basic one which I have testing on my system and to > the extent it is controlling the speed. > - Lets say if speed limit is 30 KBps then mostly will get the avg speed > around 30 to 35 KBps. > - I am using QTime for measuring time elapsed between two socket read call > and its precision is in millisecond. Looping is taking place in microsecond > and thats why I am getting almost all the time 0 as time elapsed in between > two calls. > - To solve the above problem usleep is introduced to make it sync with the > timer. > > > Diffs > ----- > > kioslave/ftp/CMakeLists.txt e080b02 > kioslave/ftp/ftp.h 0bd375b > kioslave/ftp/ftp.cpp 655524a > kioslave/ftp/speedController.h PRE-CREATION > kioslave/ftp/speedController.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102267/diff > > > Testing > ------- > > > Thanks, > > Tushar > >
