Re: playground-libs/libkvkontakte has moved to kdereview

[Christoph Feck]

On Tuesday 09 August 2011 12:07:49 Alexander Potashev wrote:
> Hi,
> 
> playground-libs/libkvkontakte moved to kdereview today. The next
> target for this project is extragear/libs. This project is a
> library for interaction with the most popular social network in
> Russia VKontakte.ru (also available at vk.com) using its public
> API documented at
> http://vkontakte.ru/pages.php?o=-1&p=Документация (only in
> Russian). libkvkontakte is already being used by
> playground-pim/akonadi-vkontakte and the KIPI export plugin for
> VKontakte which will be hopefully released with digiKam SC 2.1.0 in
> September.
> 
> Some parts of code in libkvkontakte are based on
> playground-pim/akonadi-facebook written by Thomas McGuire and
> others.
> 
> Please, review.
> Thanks.

It doesn't compile because asserts reference undeclared variables. 
Attached patch shows where the errors are.

Christoph Feck (kdepepo)
KDE Quality Team

diff --git a/libkvkontakte/allnoteslistjob.cpp b/libkvkontakte/allnoteslistjob.cpp
index e095e94..59b604a 100644
--- a/libkvkontakte/allnoteslistjob.cpp
+++ b/libkvkontakte/allnoteslistjob.cpp
@@ -32,7 +32,7 @@ AllNotesListJob::AllNotesListJob(const QString &accessToken, int uid)
 
 void AllNotesListJob::startNewJob(int offset, int count)
 {
-    Q_ASSERT(out == 0 || out == 1);
+//    Q_ASSERT(out == 0 || out == 1);
 
     NotesListJob *job = new NotesListJob(m_accessToken, m_uid, offset, count);
     connect(job, SIGNAL(result(KJob*)), this, SLOT(jobFinished(KJob*)));
@@ -67,7 +67,7 @@ void AllNotesListJob::jobFinished(KJob *kjob)
     }
     else {
         // TODO: some new notes might have been added, what should we do then?
-        Q_ASSERT(m_totalCount == listJob->totalCount());
+//        Q_ASSERT(m_totalCount == listJob->totalCount());
     }
 
     // All jobs have finished
diff --git a/libkvkontakte/authenticationdialog.cpp b/libkvkontakte/authenticationdialog.cpp
index d7da524..9c95ef1 100644
--- a/libkvkontakte/authenticationdialog.cpp
+++ b/libkvkontakte/authenticationdialog.cpp
@@ -75,7 +75,7 @@ void AuthenticationDialog::setPermissions(const QStringList &permissions)
 
 void AuthenticationDialog::start()
 {
-    Q_ASSERT(!mAppId.isEmpty());
+    Q_ASSERT(!m_appId.isEmpty());
 
     // display= {page, popup, touch, wap}
     const QString url = QString("http://api.vkontakte.ru/oauth/authorize?";