----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102188/#review5479 -----------------------------------------------------------
This review has been submitted with commit 4f0d3ec07c2ce4040af6cb822c3dc062d601852e by Albert Astals Cid to branch frameworks. - Commit On Aug. 2, 2011, 8:42 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102188/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2011, 8:42 p.m.) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > Pure Qt applications get KDE dialogs through the various > KFileDialogQtOverride members, these functions instantiate a KFileDialog that > inherits from KDialog so on KFileDialog construction we end up in > KDialogPrivate::init that calls KDialog::setButtons that uses > KStandardGuiItem::ok() that has a i18n call. Since there is no valid main > component at this stage yet once we get to the fileModule() call and it > creates a proper main component we will get the KGlobal::locale warning. > > By invoking fileModule() before creating the KFileDialog we avoid this issue. > > > Diffs > ----- > > kio/kfile/kfiledialog.cpp 4195a68 > > Diff: http://git.reviewboard.kde.org/r/102188/diff > > > Testing > ------- > > Warning is gone > > > Thanks, > > Albert > >
