On Friday 17 June 2011, Arjen Hiemstra wrote: > > On June 13, 2011, 8:05 a.m., Alexander Neundorf wrote: > > > Looks good in general. > > > > > > The foreach() loop uses new features from cmake 2.8.0, and KDE depends > > > on cmake 2.6.4 (later on this year we will require probably cmake > > > 2.8.6, then it will be fine), so this must not be used. Can you change > > > the foreach()-loop to the basic syntax ? > > > Also, the message() which is printed in the body of the loop shouldn't > > > be there, a module should only print its results, all the rest should > > > be for debugging only. > > > > > > Alex > > Could you elaborate a bit on what is wrong with the foreach loop? According > to the documentation for CMake 2.6 it also supports range-based for loops, > at least that is what > http://www.cmake.org/cmake/help/cmake2.6docs.html#command:foreach tells > me. >
Sorry, you are right. I mixed this up with the IN LIST syntax, which was new in 2.8.0. So, no objections from my side. Alex
