----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101577/#review3830 -----------------------------------------------------------
Ship it! Looks ok. - Valentin On June 10, 2011, 8:34 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101577/ > ----------------------------------------------------------- > > (Updated June 10, 2011, 8:34 p.m.) > > > Review request for KDE Base Apps. > > > Summary > ------- > > The attached patch uses the port number of a favicon's url when creating its > local cache name. This helps distinguish two severs running on the same host > as pointed out in the bug report listed above. > > > This addresses bug 124482. > http://bugs.kde.org/show_bug.cgi?id=124482 > > > Diffs > ----- > > lib/konq/favicons/favicons.cpp 8ba9258 > > Diff: http://git.reviewboard.kde.org/r/101577/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
