----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101153/ -----------------------------------------------------------
Review request for kdelibs. Summary ------- This patch completely removes this automatic change performed at the job level. If an ioslave does not do the right thing, then it needs to be fixed. I really do not see the need for the job classes to do this automatically on their own and override whatever the ioslave said was the redirection url! Can someone please shade a light as to why this was necessary when it was done ? I have not been able to decipher the reason behind it except to think that it was probably done as a cope out to hide issues in certain ioslaves. However this has now come in full circle and it prevent proper functioning of the kio_ftp ioslave. How does this affect the ftp ioslave, please look at a possible example with detailed analysis: Instead of asking the user to cancel the password dialog just to correct a typo in the username component of the url they typed in, we want to accommodate them to change the username when prompted with the password dialog. We would then perform a redirection to update the application with the changed password. Doing so almost works except for the case where the user decides to login anonymously from kio_ftp's password dialog. In that case, the username component in the redirect url will be set to blank which unfortunately gets overridden by the code this patch removes. Diffs ----- kio/kio/job.cpp 004b4c9 Diff: http://git.reviewboard.kde.org/r/101153/diff Testing ------- Thanks, Dawit
