https://bugs.kde.org/show_bug.cgi?id=496916

Albert Astals Cid <aa...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |lokalize/-/commit/3c294d0b5
                   |                            |04f8c15a476213d15d900be0ec9
                   |                            |d676

--- Comment #2 from Albert Astals Cid <aa...@kde.org> ---
Git commit 3c294d0b504f8c15a476213d15d900be0ec9d676 by Albert Astals Cid.
Committed on 03/12/2024 at 18:54.
Pushed by aacid into branch 'master'.

Make TsStorage/XliffStorage::isEmpty work again

In e7f783daddd813128aed9ef8c4fd6c092d56096d the condition

-        || (!result.isEmpty() && data && data->actionType ==
ContentEditingData::CheckLength))
was changed to
+        || (data && data->actionType == ContentEditingData::CheckLength))
on the basis that result.isEmpty was always false

Well then then correct change is to remove the || altogether not to
remove the code that is turning that check into false

M  +1    -1    src/catalog/ts/tsstorage.cpp
M  +1    -1    src/catalog/xliff/xliffstorage.cpp

https://invent.kde.org/sdk/lokalize/-/commit/3c294d0b504f8c15a476213d15d900be0ec9d676

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to