https://bugs.kde.org/show_bug.cgi?id=390310
renau...@free.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #110555|0 |1
is obsolete| |
Attachment #117477|0 |1
is obsolete| |
Attachment #175624|0 |1
is obsolete| |
--- Comment #9 from renau...@free.fr ---
Created attachment 176131
--> https://bugs.kde.org/attachment.cgi?id=176131&action=edit
Patch file
I have added a new patch that tries to address the different remarks from Paul
(https://bugs.kde.org/show_bug.cgi?id=390310#c8). We are from the the
University of Bordeaux (https://www.u-bordeaux.fr/en), in an engineering school
belonging to the Bordeaux-INP group (https://www.bordeaux-inp.fr/en).
Some things that should have been corrected :
1. The message should have been removed
2. The white space diffs should have been removed
3. The indentations should have been corrected
4. The XML output has been changed to match the existing style
Some things that are still a work-in-progress :
5. I have tried to change the regression tests, but still have
some strange behaviors on my machine (AMD64_LINUX). There are
still 2 regressions at the time :
* memcheck/tests/mismatches_xml : there is a bunch of new errors
appearing just by using some calls to VG_(printf_xml) I tried
launching the test by adding and removing all my modification, but
even putting only the modifications in
memcheck/mc_malloc_wrappers.c induce these new errors.
* tests/vg_regtest drd/tests/bar_bad_xml : same things, new errors
that appear, this time only adding the modifications in
coregrind/m_main.c, which, AFAIK, only *remove* calls to
VG_(printf_xml)
6. I have not written anything in the documentation. I imagine one
should have a look at docs/internals/xml-output-protocol4.txt or even
docs/internals/xml-output-protocol5.txt since it looks more recent.
--
You are receiving this mail because:
You are watching all bug changes.
