https://bugs.kde.org/show_bug.cgi?id=356462
Dmitry Kazakov <dimul...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/f890fcf |hics/krita/-/commit/2028c8f |d65841d4fe2817b3c12be51e211 |25ecfbfe355d4bbe3c57092ad70 |d35fb3 |da4261 --- Comment #12 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit 2028c8f25ecfbfe355d4bbe3c57092ad70da4261 by Dmitry Kazakov. Committed on 18/11/2024 at 15:07. Pushed by dkazakov into branch 'krita/5.2'. Switch KisPainter to use floating point opacity instead of 0...255 integer range Globally, we store opacity as a floating point value. It was quite weird that we converted the value to quint8, when passing to KisPainter, then back to float when passing to KoCompositeOp and then, finally, to channels_type. Now KisPainter operates with floating-point opacity value. It removes all these extra conversions and errors when rounding. # Conflicts: # libs/ui/processing/KisEncloseAndFillProcessingVisitor.cpp # libs/ui/processing/KisEncloseAndFillProcessingVisitor.h # plugins/tools/tool_enclose_and_fill/KisToolEncloseAndFill.cpp M +3 -3 benchmarks/kis_floodfill_benchmark.cpp M +1 -1 benchmarks/kis_gradient_benchmark.cpp M +1 -1 benchmarks/kis_painter_benchmark.cpp M +1 -1 libs/image/kis_fill_painter.cc M +4 -4 libs/image/kis_indirect_painting_support.cpp M +1 -1 libs/image/kis_indirect_painting_support.h M +1 -1 libs/image/kis_layer_projection_plane.cpp M +2 -2 libs/image/kis_onion_skin_compositor.cpp M +23 -6 libs/image/kis_painter.cc M +7 -3 libs/image/kis_painter.h M +1 -1 libs/image/kis_projection_leaf.cpp M +9 -1 libs/image/krita_utils.cpp M +2 -1 libs/image/krita_utils.h M +1 -1 libs/image/layerstyles/KisLayerStyleKnockoutBlower.cpp M +1 -1 libs/image/layerstyles/kis_layer_style_filter_environment.cpp M +1 -3 libs/image/layerstyles/kis_ls_utils.cpp M +3 -3 libs/image/lazybrush/kis_colorize_mask.cpp M +2 -2 libs/image/tests/kis_layer_style_projection_plane_test.cpp M +22 -0 libs/pigment/KoCompositeOp.cpp M +13 -0 libs/pigment/KoCompositeOp.h M +4 -4 libs/ui/KisView.cpp M +3 -4 libs/ui/processing/KisEncloseAndFillProcessingVisitor.cpp M +2 -2 libs/ui/processing/KisEncloseAndFillProcessingVisitor.h M +4 -4 libs/ui/processing/fill_processing_visitor.cpp M +2 -2 libs/ui/processing/fill_processing_visitor.h M +1 -1 libs/ui/tool/KisStrokeCompatibilityInfo.cpp M +1 -1 libs/ui/tool/KisStrokeCompatibilityInfo.h M +7 -9 libs/ui/tool/kis_resources_snapshot.cpp M +1 -1 libs/ui/tool/kis_resources_snapshot.h M +1 -1 libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp M +1 -1 plugins/generators/multigridpattern/multigridpatterngenerator.cpp M +1 -1 plugins/generators/pattern/patterngenerator.cpp M +1 -1 plugins/generators/solid/colorgenerator.cpp M +51 -51 plugins/paintops/colorsmudge/KisColorSmudgeStrategyBase.cpp M +15 -15 plugins/paintops/colorsmudge/KisColorSmudgeStrategyBase.h M +2 -2 plugins/paintops/colorsmudge/KisColorSmudgeStrategyLightness.cpp M +13 -14 plugins/paintops/colorsmudge/KisColorSmudgeStrategyMaskLegacy.cpp M +4 -4 plugins/paintops/colorsmudge/KisColorSmudgeStrategyMaskLegacy.h M +4 -4 plugins/paintops/curvebrush/kis_curve_paintop.cpp M +3 -3 plugins/paintops/defaultpaintops/brush/kis_brushop.cpp M +1 -1 plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp M +2 -2 plugins/paintops/deform/kis_deform_paintop.cpp M +1 -1 plugins/paintops/gridbrush/kis_grid_paintop.cpp M +2 -2 plugins/paintops/hairy/kis_hairy_paintop.cpp M +2 -2 plugins/paintops/hatching/kis_hatching_paintop.cpp M +6 -6 plugins/paintops/libpaintop/KisFlowOpacityOption.cpp M +1 -1 plugins/paintops/libpaintop/KisFlowOpacityOption.h M +5 -5 plugins/paintops/libpaintop/KisOpacityOption.cpp M +1 -1 plugins/paintops/libpaintop/KisOpacityOption.h M +1 -1 plugins/paintops/mypaint/MyPaintSurface.cpp M +6 -4 plugins/paintops/sketch/kis_sketch_paintop.cpp M +2 -2 plugins/paintops/spray/kis_spray_paintop.cpp M +2 -2 plugins/paintops/spray/spray_brush.cpp M +2 -2 plugins/paintops/tangentnormal/kis_tangent_normal_paintop.cpp M +3 -3 plugins/tools/basictools/kis_tool_fill.cc M +1 -1 plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp M +1 -1 plugins/tools/tool_enclose_and_fill/KisToolEncloseAndFill.cpp https://invent.kde.org/graphics/krita/-/commit/2028c8f25ecfbfe355d4bbe3c57092ad70da4261 -- You are receiving this mail because: You are watching all bug changes.