https://bugs.kde.org/show_bug.cgi?id=496388
Bug ID: 496388 Summary: The image->monitor color conversion doesn't update with flag changes. Classification: Applications Product: krita Version: nightly build (please specify the git hash!) Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: Color models Assignee: krita-bugs-n...@kde.org Reporter: griffinval...@gmail.com Target Milestone: --- SUMMARY After some experimentation here (https://krita-artists.org/t/soft-proofing-doesnt-match-converted-image/104157/37), I realized that Krita only updates the monitor color transform after the monitor profile has been changed, but not for intent or any of the flags (lcms optimisation or blackpoint compensation). >From some basic debugging, the issue is that KisCanvas2::slotConfigChanged() calls KisCanvas2::slotScreenChanged which calls KisCanvas2::setDisplayProfile(const KoColorProfile *monitorProfile) and eventually that sets the profile on isDisplayColorConverter::setMonitorProfile(const KoColorProfile *monitorProfile), which also updates all the extra options. However, if the profile didn't change, this last function is never called. STEPS TO REPRODUCE 1. Convert any given image (with black sections) to CMYK. 2. Switch off (or on) blackpoint compensation in settings->color management. 3. Observe canvas. 4. Change monitor profile in settings->color management. Turning on or off blackpoint compensation should change whether or not CMYK black is adjusted for or not (CMYK is usually not as black as a monitor, and the profile usually simulates this... blackpoint compensation maps the blacks of two color spaces), so the blacks should change when BP compensation is changed. OBSERVED RESULT Blackpoint compensation changes are only in effect when the monitor profile changes. EXPECTED RESULT Blackpoint compensation should take effect even when the monitor profile doesn't change. -- You are receiving this mail because: You are watching all bug changes.