https://bugs.kde.org/show_bug.cgi?id=495925
Waqar Ahmed <waqar....@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/fram
| |eworks/ktexteditor/-/commit
| |/792a1786cdfa4ec1cb5b9fa3ca
| |710ffe41b55ed7
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Waqar Ahmed <waqar....@gmail.com> ---
Git commit 792a1786cdfa4ec1cb5b9fa3ca710ffe41b55ed7 by Waqar Ahmed.
Committed on 07/11/2024 at 17:21.
Pushed by cullmann into branch 'master'.
Fix crash if feedback or dyn attr is cleared before deletion
We only notify about deleted range in the dtor if a range has feedback
or a dynamic attribute. That will not work if someone clears the
feedback or attribute before deletion.
To safeguard against this, notify about this change if the feedback/
attribute gets unset.
Note that the parameter is called "deletedRange" which isn't really
accurate anymore and needs to be renamed but I am not really sure
what to name it.
Ideally the view or anyone else wouldn't store non-owning range pointers
like this. I don't have any good ideas about a safer "handle" that also
performs well atm so leaving it as is.
M +42 -0 autotests/src/movingrange_test.cpp
M +2 -0 autotests/src/movingrange_test.h
M +17 -2 src/buffer/katetextrange.cpp
https://invent.kde.org/frameworks/ktexteditor/-/commit/792a1786cdfa4ec1cb5b9fa3ca710ffe41b55ed7
--
You are receiving this mail because:
You are watching all bug changes.
