https://bugs.kde.org/show_bug.cgi?id=493111
Jakob Petsovits <jpe...@petsovits.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/plas
| |ma/powerdevil/-/commit/d9f5
| |8068be5acafb065fbab2aae6f90
| |b68776557
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Jakob Petsovits <jpe...@petsovits.com> ---
Git commit d9f58068be5acafb065fbab2aae6f90b68776557 by Jakob Petsovits.
Committed on 07/10/2024 at 15:05.
Pushed by jpetso into branch 'master'.
daemon/actions/dimdisplay: Set brightness separately per display
With 6.2's per-display brightness changes, setBrightness()
under Wayland will, in many setups, affect multiple displays
with different perceived screen brightness for a given
brightness percentage.
Before this patch, the DimDisplay action would only remember a
single brightness value (of the first display) and then set this
value to potentially multiple displays when dimming stops again.
This would lead to brightness transitions like this:
* internal display: 50% -> dimmed 15% -> 50%
* external display: 100% -> dimmed 15% -> 50%
Instead, dimming adjustments should apply to each display
individually, like this:
* internal display: 50% -> dimmed 15% -> 50%
* external display: 100% -> dimmed 30% -> 100%
This commit makes it work that way. Non-dimmed brightness values
are stored in a map, one value for each display that was connected
at the time the dimming started. When restoring, these individual
brightness values will be restored to all displays that are still
connected.
This brings the original DimDisplay code in line with the new
per-display brightness API. It still won't save you from bugs
about dimming changes while one of your displays is disconnected.
PowerDevil issue #38 provides a more comprehensive plan for
making multi-monitor dimming with disconnections actually robust.
M +68 -22 daemon/actions/bundled/dimdisplay.cpp
M +5 -2 daemon/actions/bundled/dimdisplay.h
https://invent.kde.org/plasma/powerdevil/-/commit/d9f58068be5acafb065fbab2aae6f90b68776557
--
You are receiving this mail because:
You are watching all bug changes.
