https://bugs.kde.org/show_bug.cgi?id=492302
Philip C <cliabh...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/netw
| |ork/kdeconnect-android/-/co
| |mmit/db615b82df9eb9d6a8a14f
| |3d061868a90f4f1395
--- Comment #7 from Philip C <cliabh...@gmail.com> ---
Git commit db615b82df9eb9d6a8a14f3d061868a90f4f1395 by Philip Cohn-Cort, on
behalf of Marko Zajc.
Committed on 21/09/2024 at 22:24.
Pushed by philipc into branch 'master'.
Fix trusted networks
## Summary
1) Fix the code responsible for loading the trusted network list.
2) The old `#_#` delimiter has been replaced with a less likely NUL character.
This requires re-adding trusted networks, so I can revert it if necessary.
3) Ignore incoming identity packets on untrusted devices if they come from an
untrusted device.
## Test Plan
### Before:
1) Trusted networks were completely broken, an would show variations of `#` and
`_` on the list due to a bug in the splitting code.
2) Any network with `#_#` in the SSID - although unlikely - would not be
possible to use as a trusted network.
3) The device was still discoverable on an untrusted network by manually
refreshing the devices list.
### After:
1) Trusted networks now load the SSID list correctly.
2) Networks with `#_#` in the SSID can be added as trusted networks.
3) The device is no longer discoverable on an untrusted network.
M +26 -10 src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java
M +4 -3 src/org/kde/kdeconnect/Helpers/TrustedNetworkHelper.kt
https://invent.kde.org/network/kdeconnect-android/-/commit/db615b82df9eb9d6a8a14f3d061868a90f4f1395
--
You are receiving this mail because:
You are watching all bug changes.
