https://bugs.kde.org/show_bug.cgi?id=469782

--- Comment #8 from Mikhail Gorodetsky <mihmih1...@gmail.com> ---
> BTW. Is this zstd.h file "generated" from the upstream sources? Then we might 
> have to adjust the (upstream) generator program (and document clearly how to 
> regenerate to update the zstd version when needed.

Initially, zstd.h indeed generated here:
https://github.com/facebook/zstd/tree/dev/build/single_file_libs . But then all
malloc, free and such are replaced with valgrind counterparts, manually.

> Yes, or simply add the text of those to the zstd.h file (they are short 
> enough and imho it is slightly more convenient to just have them inline where 
> possible).

So, I should add GPLv2 and BSD licenses text at the beginning of zstd.h and
probably zstd.c, and above them a short instruction how to regenerate the files
in the futute, and replace "found in the <FILENAME> file in the root directory
of this source tree" with "found at the beginning of this file". Did I miss
anything?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to