https://bugs.kde.org/show_bug.cgi?id=488946
Bug ID: 488946
Summary: Invalid CMake syntax for !BUILD_WITH_QT6
Classification: Applications
Product: amarok
Version: unspecified
Platform: Compiled Sources
OS: All
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: amarok-bugs-d...@kde.org
Reporter: joe.y...@gmail.com
Target Milestone: kf5
SUMMARY
Commit 5cf29c0bd9b0536a04624db15644b175054b8c5e (after 3.0.1) introduced a
CMake build option for Qt6. The CMake checks that flag with if(!BUILD_WITH_QT6)
in a few places. if(NOT BUILD_WITH_QT6) is the correct syntax. Building without
QT6 leads to missing files (e.g. amarok-plugin.desktop,
amarok-contextapplet.desktop, amarok_codecinstall.desktop)
STEPS TO REPRODUCE
1. Build amarok from git without BUILD_WITH_QT6 set
OBSERVED RESULT
Missing files from the installation.
amarok-plugin.desktop
amarok-contextapplet.desktop
amarok_codecinstall.desktop
amarokurls/amarok.protocol
amarokitpc.protocol
amarok_collection-mysqlcollection.desktop
amarok_storage-mysqlestorage.desktop
amarok_storage-mysqlserverstorage.desktop
amarok_service_ampache.desktop
amarok_service_ampache_config.desktop
amarok_service_lastfm.desktop
amarok_service_lastfm_config.desktop
amaroklastfm.protocol
amarok_service_magnatunestore.desktop
amarok_service_magnatunestore_config.desktop
EXPECTED RESULT
The amarok installation includes the missing files.
SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 24.04
(available in About System)
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.13
ADDITIONAL INFORMATION
I caught this in the nightly builds in my PPA when packaging failed due to the
missing files. I tested a fix by changing it from !BUILD_WITH_QT6 to NOT
BUILD_WITH_QT6 and that worked.
--
You are receiving this mail because:
You are watching all bug changes.
