[valgrind] [Bug 484480] False positives when using sem_trywait

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=484480

Paul Floyd <pjfl...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jsew...@acm.org             |pjfl...@wanadoo.fr

--- Comment #3 from Paul Floyd <pjfl...@wanadoo.fr> ---
Comment in hg_intercepts.c

   Unhandled:
     int sem_trywait(sem_t *sem);
     int sem_timedwait(sem_t *restrict sem,
                       const struct timespec *restrict abs_timeout);

I looked at DRD, it just does the same thing as sem_wait so I tried this code
on FreeBSD

__attribute__((noinline))
static int sem_trywait_WRK(sem_t* sem)
{
   OrigFn fn;
   int    ret;
   VALGRIND_GET_ORIG_FN(fn);

   if (TRACE_SEM_FNS) {
      fprintf(stderr, "<< sem_trywait(%p) ", sem);
      fflush(stderr);
   }

   DO_CREQ_v_W(_VG_USERREQ__HG_POSIX_SEM_WAIT_PRE, sem_t*,sem);

   CALL_FN_W_W(ret, fn, sem);

   DO_CREQ_v_WW(_VG_USERREQ__HG_POSIX_SEM_WAIT_POST, sem_t*,sem,
                long, (ret == 0) ? True : False);

   if (ret != 0) {
      DO_PthAPIerror( "sem_trywait", SEM_ERROR );
   }

   if (TRACE_SEM_FNS) {
      fprintf(stderr, " sem_trywait -> %d >>\n", ret);
      fflush(stderr);
   }

   return ret;
}

#if defined(VGO_freebsd)
   LIBC_FUNC(int, semZutrywait, sem_t* sem) { /* sem_trywait */
      return sem_trywait_WRK(sem);
   }
#endif

and it seems to work.

I'll clean the code up (and add sem_timedwait) sometime this weekend.

-- 
You are receiving this mail because:
You are watching all bug changes.