https://bugs.kde.org/show_bug.cgi?id=481594

Nicolas Fella <nicolas.fe...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-desktop/-/commit/
                   |                            |79070f0646c47554f126b8c3aee
                   |                            |55570d2c61dd0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit 79070f0646c47554f126b8c3aee55570d2c61dd0 by Nicolas Fella, on behalf
of Harald Sitter.
Committed on 21/02/2024 at 13:21.
Pushed by nicolasfella into branch 'master'.

kcms/plasmasearch: don't crash on dragging favorties to the end

snap it back to the end instead.

this happens because the pluginselector doodad is a singular list view
with sections. when the user drags an item from the favorites section to
the available section, to reorder an item at the bottom, the new drop
index is inside the model but not inside the m_favoriteMetaDataList.
i.e. its index is model-bound not m_favoriteMetaDataList-bound. we
therefore need to clamp the index at the upper bounds of
m_favoriteMetaDataList manually so as to not work with invalid indexes

M  +6    -1    kcms/runners/plasmasearch/kcm.cpp
M  +1    -1    kcms/runners/plasmasearch/kcm.h

https://invent.kde.org/plasma/plasma-desktop/-/commit/79070f0646c47554f126b8c3aee55570d2c61dd0

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to