https://bugs.kde.org/show_bug.cgi?id=475745
--- Comment #5 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit b005afc5b03c160e504116798a99e1caa7ba4cb6 by Dmitry Kazakov. Committed on 02/02/2024 at 17:10. Pushed by dkazakov into branch 'master'. Fix artifacts when changing transform mask continuously The patch implements multiple things: 1) Makes static cache storage in the transform mask thread-safe and encapsulated in a single structure. 2) Makes sure that KisRecalculateTransformMaskJob::run() cannot run twice for the same parameters. Now it is governed by m_mask->staticImageCacheIsValid() check in the beginnig of the function. The multiple invocations could happen due to concurrent calls to KisTransformMask::slotDelayedStaticUpdate() (by the timer) and KisTransformMask::threadSafeForceStaticImageUpdate() (by an undo command). That could happen in the beginning of the transformation stroke. Now the two calls will be compressed by the cache validity check. 3) InplaceTransformStrokeStrategy does a better job in maintaining updates for the final lod0 update of the lodN stroke. 4) Implements a unittest for testing the inplace stroke strategy. Alas its results are not very stable, so it is marked as broken for now. M +1 -0 libs/image/CMakeLists.txt A +10 -0 libs/image/KisTransformMaskTestingInterface.cpp [License: GPL(v2.0+)] A +25 -0 libs/image/KisTransformMaskTestingInterface.h [License: GPL(v2.0+)] M +8 -1 libs/image/kis_recalculate_transform_mask_job.cpp M +2 -1 libs/image/kis_recalculate_transform_mask_job.h M +197 -64 libs/image/kis_transform_mask.cpp M +11 -1 libs/image/kis_transform_mask.h M +9 -2 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +5 -0 plugins/tools/tool_transform2/tests/CMakeLists.txt A +627 -0 plugins/tools/tool_transform2/tests/TransformStrokeStrategyTest.cpp [License: GPL(v2.0+)] A +24 -0 plugins/tools/tool_transform2/tests/TransformStrokeStrategyTest.h [License: GPL(v2.0+)] A +- -- plugins/tools/tool_transform2/tests/data/inplace-lod0-cancelled/inplace-lod0-cancelled_autobrush_300px.kpp_indirect_cancelled_internal.png A +- -- plugins/tools/tool_transform2/tests/data/inplace-lod0-continue-and-cancel/inplace-lod0-continue-and-cancel_autobrush_300px.kpp_indirect_cancelled_internal.png A +- -- plugins/tools/tool_transform2/tests/data/inplace-lod0/inplace-lod0_autobrush_300px.kpp_indirect_finished_internal.png A +- -- plugins/tools/tool_transform2/tests/data/inplace-lod2-cancelled/inplace-lod2-cancelled_autobrush_300px.kpp_indirect_cancelled_internal.png A +- -- plugins/tools/tool_transform2/tests/data/inplace-lod2-continue-and-cancel/inplace-lod2-continue-and-cancel_autobrush_300px.kpp_indirect_cancelled_internal.png A +- -- plugins/tools/tool_transform2/tests/data/inplace-lod2/inplace-lod2_autobrush_300px.kpp_indirect_finished_internal.png M +23 -2 sdk/tests/stroke_testing_utils.cpp M +4 -0 sdk/tests/stroke_testing_utils.h https://invent.kde.org/graphics/krita/-/commit/b005afc5b03c160e504116798a99e1caa7ba4cb6 -- You are receiving this mail because: You are watching all bug changes.
