https://bugs.kde.org/show_bug.cgi?id=371210
Bug ID: 371210
Summary: patch review shouldn't add files it opens to the
recent files menu
Product: kdevplatform
Version: unspecified
Platform: Compiled Sources
OS: All
Status: UNCONFIRMED
Severity: wishlist
Priority: NOR
Component: patchreview
Assignee: kdevelop-bugs-n...@kde.org
Reporter: rjvber...@gmail.com
CC: david.nolden....@art-master.de
The patch review plugin can open quite a few files, which aren't always files
you have been editing - for instance when you rename a directory and commit the
resulting change (which KDevelop sadly records as separate delete/create events
rather than renames which git does support).
When you commit or review changes to a file you've been editing that file will
most likely already be in the recent files menu, or at least it won't surprise
appearing there. If however that change has been pending for some time there
still isn't much of a reason to add the file to the list of recent documents.
Reproducible: Always
Steps to Reproduce:
1. commit or review changes that include files you haven't touched for a while
or at all (other than renaming them or the directory they live in)
2. close the review toolview
3. try to open a file from the recent files menu
Actual Results:
If the patch review concerned enough files, the whole recent files menu will be
populated with the reviewed files. This just happened to me, and it took me a
while to understand why the list contained only unfamiliar files all of a
sudden.
Expected Results:
Ideally the recent files menu would only contain files you have actually opened
yourself
Supposing it is not trivial to decide on the fly whether or not a file being
opened should be added to the recent files menu, this could be achieved more or
less easily by (order of personal preference):
- opening only the patchfile in review mode and letting the user open any
modified file s/he is interested in by double-clicking in the list of modified
files (which is an existing functionality)
- maintaining separate lists of recent files for the review and other modes.
--
You are receiving this mail because:
You are watching all bug changes.
