https://bugs.kde.org/show_bug.cgi?id=477039
Kevin Ottens <er...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |er...@kde.org
--- Comment #5 from Kevin Ottens <er...@kde.org> ---
So now we got a MR for KIO which should fix this. Indeed, Lokalize seems to
exploit a corner case in KDirModel's API and the previous patch slightly
changed the behavior for this particular case.
This being said, it's one of those where I think we can consider the bug
"shared" between KDirModel and Lokalize. It looks like this just uncovered
another bug in Lokalize itself, I suspect it didn't really work as it should
previously and might have cases where it'd break anyway.
Indeed, the project model wrapping KDirModel in Lokalize seems to use rowCount
but not canFetchMore/fetchMode to decide to go one level down the hierarchy.
This is a bit optimistic in the general case since models (like KDirModel) can
decide to not eagerly fetch children nodes. Also it set an invalid url as the
root of the model which is allowed but I think a bit fishy.
I don't know Lokalize enough to feel confident investing the time to look
deeper into how this project model works, I'd probably just unwillingly break
it. Also, the MR in KIO does the job for now... still revisiting the project
model in Lokalize might be worth it at some point.
--
You are receiving this mail because:
You are watching all bug changes.
