https://bugs.kde.org/show_bug.cgi?id=474982

Jin Liu <ad.liu....@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|UPSTREAM                    |---

--- Comment #14 from Jin Liu <ad.liu....@gmail.com> ---
The current implementation doesn't make sense at all...

The manual switch is bound to the data engine "PowerManagement" "Has
Inhibition":
https://github.com/KDE/plasma-workspace/blob/e254bf301a560b9d6d70968ac43a587edab7fe19/applets/batterymonitor/package/contents/ui/PowerManagementItem.qml#L41

Which bounds to org.freedesktop.PowerManagement.Inhibit.HasInhibitChanged:
https://github.com/KDE/plasma-workspace/blob/de5a5dbf63c5d1fb91c1cf3a3f45553b9cca417b/dataengines/powermanagement/powermanagementengine.cpp#L219

The problem is the FDO service returns HasInhibit=true for *any* inhibitors. So
this code would treat any inhibitor as manually enabled in the applet.

The correct implementation would be that Powerdevil manages a special "KDE
manual inhibitor" whose state can be queried individually.

BTW, I don't see why the applet hides inhibitors when the manual switch is on.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to