https://bugs.kde.org/show_bug.cgi?id=472862
--- Comment #24 from Harald Sitter <sit...@kde.org> --- Git commit 65b6b7537dd3e844cb1d4ff54347de28fc34d58d by Harald Sitter. Committed on 13/11/2023 at 14:02. Pushed by sitter into branch 'kf5'. kdirwatch: always unref d, and unset d from inside d previously we could fall into a trap when the current thread for whatever reason has no local data (e.g. the dtor is invoked from the wrong thread). when that happened we would leave our d untouched and never unref, which then causes particularly hard to track down problems because we can crash at a much later point in time when the d tries to send an event to the since-deleted KDirWatch instance. instead let's revisit this a bit... the reason the `dwp_self.hasLocalData()` check was added is because of destruction order between QThreadStorage (the d) and QGlobalStatic (the ::self()) specifically because of this caveat from the QThreadStorage documentation: > QThreadStorage can be used to store data for the main() thread. QThreadStorage deletes all data set for the main() thread when QApplication is destroyed, regardless of whether or not the main() thread has actually finished. versus QGlobalStatic: > If the object is created, it will be destroyed at exit-time, similar to the C atexit function. This effectively means that QThreadStorage (at least on the main() thread) will destroy BEFORE QGlobalStatic. To bypass this problem the dwp_self check was added to conditionally skip unrefing when the QThreadStorage had already cleaned up. The trouble is that this then hides the mentioned scenario where we have a d but no backing data because of poor thread management. Instead improve our management of the pimpl: In ~KDirWatchPrivate we now unset the d pointer of all still monitoring KDirWatch. This allows us to unconditionally check for d in the ~KDirWatch so it always unrefs/removes itself from KDirWatchPrivate. In the shutdown scenario cleanup runs the other way around... KDirWatchPrivate cleans up and unsets itself as d pointer, thereby turning ~KDirWatch effectively no-op so when it runs afterwards it won't access any Private memory anymore. (cherry picked from commit 436e38ad511b44432be1be31dc4ed27383e4338a) M +11 -1 src/lib/io/kdirwatch.cpp M +1 -0 src/lib/io/kdirwatch.h https://invent.kde.org/frameworks/kcoreaddons/-/commit/65b6b7537dd3e844cb1d4ff54347de28fc34d58d -- You are receiving this mail because: You are watching all bug changes.
