https://bugs.kde.org/show_bug.cgi?id=476592
Nicolas Fella <nicolas.fe...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/plas
| |ma/xdg-desktop-portal-kde/-
| |/commit/bb974d5c052557a5aca
| |4c3c16606bbb4c24b5e2d
Status|ASSIGNED |RESOLVED
--- Comment #2 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit bb974d5c052557a5aca4c3c16606bbb4c24b5e2d by Nicolas Fella, on behalf
of Bharadwaj Raju.
Committed on 08/11/2023 at 11:13.
Pushed by nicolasfella into branch 'master'.
Use QDBusVariant::variant() instead of QVariant::fromValue()
The former produces a QVariant of the type that QDBusVariant held, while
the latter produces a QVariant of type QDBusVariant itself. This affects
our return type according to DBus.
Simple test:
```cpp
auto x = QVariant::fromValue(readFdoColorScheme());
auto y = readFdoColorScheme().variant();
qDebug() << x.typeName() << y.typeName();
```
M +2 -2 src/settings.cpp
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/bb974d5c052557a5aca4c3c16606bbb4c24b5e2d
--
You are receiving this mail because:
You are watching all bug changes.
