https://bugs.kde.org/show_bug.cgi?id=471942
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/plasma-desktop/-/commit/
| |8671deb12554b659cae119d7d6f
| |069682dcd6221
Resolution|--- |FIXED
--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit 8671deb12554b659cae119d7d6f069682dcd6221 by Nate Graham, on behalf
of Jakob Petsovits.
Committed on 26/07/2023 at 19:10.
Pushed by ngraham into branch 'master'.
kcms/{mouse,touchpad}: Make "Apply" button work all the time
The (more or less identical) instantiations of QQuickWidget in the
libinput backends of Mouse and Touchpad KCMs are connecting the
QML file's changeSignal() to the C++ class's onChange() slot.
However, this does not work when the QQuickWidget hasn't yet
completed loading of the QML file. The signal doesn't yet exist.
As a result, when System Settings is started with kcm_mouse or
kcm_touchpad explicitly (e.g. via KRunner or CLI), onChange() is
never called and the "Apply" button remains greyed out, even if
changes are made in the UI.
The fix is to connect QQuickWidget::rootObject() only once the
QQuickWidget itself has signaled its readiness, via statusChanged().
Connecting statusChanged() is done before setSource() is called,
to eliminate any concerns about when readiness is reached.
(It could be ready immediately if the resource was already loaded!)
M +6 -1 kcms/mouse/kcm/libinput/libinput_config.cpp
M +6 -1 kcms/touchpad/kcm/libinput/touchpadconfiglibinput.cpp
https://invent.kde.org/plasma/plasma-desktop/-/commit/8671deb12554b659cae119d7d6f069682dcd6221
--
You are receiving this mail because:
You are watching all bug changes.
