https://bugs.kde.org/show_bug.cgi?id=464032
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/-/commit/f54e8cf
| |230c9b3d8a1ef433f1a283579f3
| |16a593
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #16 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit f54e8cf230c9b3d8a1ef433f1a283579f316a593 by Dmitry Kazakov.
Committed on 11/07/2023 at 12:54.
Pushed by dkazakov into branch 'master'.
Fix crashes when trying to play animation
The sequence of event was really complicated. It turned out that under some
rare circumstances background cache populator and the interactive
cache generation could start the generation process concurrently. It
caused the following:
1) KisAsyncAnimationRendererBase::notifyFrameCompleted() caught an
"unexpected frame" assert:
KIS_SAFE_ASSERT_RECOVER_RETURN(m_d->requestedFrame == frame);
2) Triggering this assert skipped the clearFrameRegenerationState() call
3) Skipping the clearFrameRegenerationState() call, caused the
texturing info objects to be used twice. But, the textures
caching uses a (home-grown) move-semantics, so, on the second call,
the textures contained no actual data.
4) Null pointers in the data caused the crashes in the end.
5) Incorrect fix for bug 436283 (which was actually the same bug)
actually hid the bug and moved the crash down the execution path,
making it harder to track down.
The patch also implements a simple wrapper class KisAdaptedLock, which
allows converting any lockable object with non-standard interface
into std::unique_lock().
A +92 -0 libs/global/KisAdaptedLock.h [License: GPL(v2.0+)]
M +3 -14 libs/global/KisCursorOverrideLock.h
M +2 -0 libs/image/CMakeLists.txt
A +24 -0 libs/image/KisBlockBackgroundFrameGenerationLock.cpp
[License: GPL(v2.0+)]
A +37 -0 libs/image/KisBlockBackgroundFrameGenerationLock.h [License:
GPL(v2.0+)]
A +30 -0 libs/image/KisLockFrameGenerationLock.cpp [License:
GPL(v2.0+)]
A +35 -0 libs/image/KisLockFrameGenerationLock.h [License:
GPL(v2.0+)]
M +37 -2 libs/image/kis_image_animation_interface.cpp
M +65 -1 libs/image/kis_image_animation_interface.h
M +5 -1 libs/image/kis_regenerate_frame_stroke_strategy.cpp
M +5 -2 libs/image/kis_regenerate_frame_stroke_strategy.h
M +4 -4 libs/ui/KisAsyncAnimationRendererBase.cpp
M +3 -2 libs/ui/KisAsyncAnimationRendererBase.h
M +1 -1 libs/ui/KisDocument.cpp
M +17 -1 libs/ui/dialogs/KisAsyncAnimationRenderDialogBase.cpp
M +43 -17 libs/ui/kis_animation_cache_populator.cpp
M +2 -2 libs/ui/kis_async_action_feedback.cpp
M +42 -1 libs/ui/kis_async_action_feedback.h
M +10 -2
plugins/dockers/storyboarddocker/KisStoryboardThumbnailRenderScheduler.cpp
https://invent.kde.org/graphics/krita/-/commit/f54e8cf230c9b3d8a1ef433f1a283579f316a593
--
You are receiving this mail because:
You are watching all bug changes.
