https://bugs.kde.org/show_bug.cgi?id=471195
ratijas <m...@ratijas.tk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|REPORTED |CONFIRMED
--- Comment #3 from ratijas <m...@ratijas.tk> ---
[[replied on GitHub, copy-pasting my reply here]]
I apologize for the mistake we made during refactoring.
> setPrimary() ignores its argument. My guess is that it's an incomplete draft
> that has popped up in the release by mistake
Less like a draft, and more like a rotten piece that was left around unused by
libkscreen and thus untested. 🥴
The call to `setPriority(1)` should be guarded by an `if (primary)` condition.
But there's not much meaningful we can do for the reverse `!primary` case.
> they have a plan to give priorities to outputs, instead of making one of them
> primary
Indeed, the new and more robust way is to set priorities, which are also
maintained to be unique and sequential by the Config object. One should not
call priority-related methods on Outputs directly. I wanted to make them
protected from outside access (`friend class Config`) but that proposal got
rejected.
> Maybe the "bug" was introduced to get people to migrate to a "new API"?
Most certainly not. But if your code calls `Output::setPrimary`, it better be
ported to `config->setPrimaryOutput`
--
You are receiving this mail because:
You are watching all bug changes.
