https://bugs.kde.org/show_bug.cgi?id=369175
--- Comment #22 from Julian Seward <jsew...@acm.org> ---
Looking for helper calls in the the whole of guest_ppc_toIR.c, by searching for
the
string "mkIRExprVec_", I found the following non-wrapped uses of function
pointers. They should all be wrapped in fnptr_to_fnentry(). The reason
for my claim of "impossible" in comment 21 is that I would have thought that
the BCD test cases exercise all of these helper functions, so any missing
wrapper would cause the case to segfault. So maybe we don't really yet
understand what is going on.
static IRExpr * is_BCDstring128 (UInt Signed, IRExpr *src)
&is_BCDstring128_helper,
static IRTemp increment_BCDstring (IRExpr *src, IRExpr *carry_in)
&increment_BCDstring32_helper,
&increment_BCDstring32_helper,
&increment_BCDstring32_helper,
&increment_BCDstring32_helper,
static IRExpr * convert_to_zoned ( IRExpr *src, IRExpr *upper_byte )
&convert_to_zoned_helper,
&convert_to_zoned_helper,
static IRExpr * convert_to_national ( IRExpr *src ) {
&convert_to_national_helper,
&convert_to_national_helper,
static IRExpr * convert_from_zoned ( IRExpr *src ) {
&convert_from_zoned_helper,
static IRExpr * convert_from_national ( IRExpr *src ) {
&convert_from_national_helper,
static Bool dis_av_load ( const VexAbiInfo* vbi, UInt theInstr )
&ppc64g_dirtyhelper_LVS,
(although this one doesn't matter, because it is LE only. Still, inconsistent)
same for lvsr a few lines later
--
You are receiving this mail because:
You are watching all bug changes.
