https://bugs.kde.org/show_bug.cgi?id=405135

Daniel Vrátil <dvra...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.2.1
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-pass/commit/4958d
                   |                            |156d682c2a9fe97887244ff7ad4
                   |                            |c56b321c
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Daniel Vrátil <dvra...@kde.org> ---
Git commit 4958d156d682c2a9fe97887244ff7ad4c56b321c by Daniel Vrátil.
Committed on 01/03/2023 at 21:59.
Pushed by dvratil into branch 'master'.

Fix entire clipboard history being always wiped by Plasma Pass

Modern Klipper supports x-kde-passwordManagerHint and won't store
items marked with this hint in the clipboard history. Back when
I was writing Plasma Pass this feature wasn't merged yet. Plasma
Pass was ready for it but it also had to support the current version
of Klipper at that time, so it always go and try to remove the password
from Klipper's history.

When new Klipper with support for x-kde-passwordManagerHint was released
Plasma Pass would still try to remove the password from Klipper's
clipboard history but would always fail (since Klipper doesn't store
passwords in history anymore). This would trigger a safety fallback
inside Plasma Pass that just wipes entire Klipper history, just to
be sure.

With this fix, Plasma Pass will only attempt to remove the password
from Klipper's history if it detects an old Klipper that doesn't support
the hint yet.
FIXED-IN: 1.2.1

M  +2    -0    plugin/CMakeLists.txt
A  +61   -0    plugin/klipperutils.cpp     [License: LGPL(v2.1+)]
A  +20   -0    plugin/klipperutils.h     [License: LGPL(v2.1+)]
M  +27   -2    plugin/providerbase.cpp
M  +4    -0    plugin/providerbase.h

https://invent.kde.org/plasma/plasma-pass/commit/4958d156d682c2a9fe97887244ff7ad4c56b321c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to