https://bugs.kde.org/show_bug.cgi?id=465449

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |6.0
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/commit/
                   |                            |aaf42575e497a4aa6a856d518fd
                   |                            |bafaf77ae7537
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Nate Graham <n...@kde.org> ---
Git commit aaf42575e497a4aa6a856d518fdbafaf77ae7537 by Nate Graham.
Committed on 10/02/2023 at 14:06.
Pushed by ngraham into branch 'master'.

kcms/region/language: Warn for more invalid language combinations

We currently warn the user when they configure American English (en_US)
as their first language with any other languages underneath it--because
it causes a mix of languages to be shown in the UI and confuses the heck
out of people.

But we only check if the top language is en_US! There are other
Englishes too that technically count as full languages--such as en_GB.
If the user makes en_GB their top language and then puts any other
non-English language under it, the same thing happens as the system will
fall back to the second non-English language for any string that isn't
found in the British English translation catalogue, which turns out to
be a lot. What a person using en_GB actually wants is to fall back to
en_US, which is the implicit default and happens when there are no other
languages configured beneath en_GB.

To fix this, let's change the check to encompass all en_* languages, not
just en_US. Hopefully making the warning text appear for these use cases
will be good enough and we won't have to do something drastic like
secretly insert en_US after the last non-en_US English language, and C
after the last en_* language of any kind when there are other non-en_*
languages underneath it in the language list.
FIXED-IN: 6.0

M  +1    -1    kcms/region_language/languagelistmodel.cpp
M  +1    -1   
kcms/region_language/package/contents/ui/AdvancedLanguageSelectPage.qml

https://invent.kde.org/plasma/plasma-workspace/commit/aaf42575e497a4aa6a856d518fdbafaf77ae7537

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to