https://bugs.kde.org/show_bug.cgi?id=462279

Stefano Crocco <stefano.cro...@alice.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/konqueror/commit/8631b1
                   |                            |b7d68f1541ba61b6574327a334b
                   |                            |f0b2411
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Stefano Crocco <stefano.cro...@alice.it> ---
Git commit 8631b1b7d68f1541ba61b6574327a334bf0b2411 by Stefano Crocco.
Committed on 05/02/2023 at 16:07.
Pushed by stefanocrocco into branch 'master'.

Download URLs requested with the POST method directly from WebEnginePart

WebEnginePart can't pass the POST data to KIO, as QtWebEngine doesn't
provide it, so using KIO would lead to unexpected results. The
workaround is to treat URLs downloaded with POST in the same way
WebEnginePart already does with blob URLs.

An additional problem is that `QtWebEngine` doesn't provide an easy way
to find out, ad download time, if the file is the response to a POST
request or not: that information is only available to
`QWebEngineUrlRequestInterceptor`,
so I had to store that information and try to match it with the page which
made the request (`QWebEngineUrlRequestInterceptor` only knows about the
request but not about who made it). The algorithm is not always correct,
but it should only fail in some specific circumstances

M  +1    -0    webenginepart/src/CMakeLists.txt
A  +72   -0    webenginepart/src/navigationrecorder.cpp     [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
A  +129  -0    webenginepart/src/navigationrecorder.h     [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
M  +7    -1    webenginepart/src/webenginepage.cpp
M  +2    -2    webenginepart/src/webenginepage.h
M  +10   -2    webenginepart/src/webenginepartcontrols.cpp
M  +5    -1    webenginepart/src/webenginepartcontrols.h
M  +36   -30   webenginepart/src/webenginepartdownloadmanager.cpp
M  +26   -9    webenginepart/src/webenginepartdownloadmanager.h
M  +1    -1    webenginepart/src/webengineparterrorschemehandler.cpp
M  +5    -0    webenginepart/src/webengineurlrequestinterceptor.cpp

https://invent.kde.org/network/konqueror/commit/8631b1b7d68f1541ba61b6574327a334bf0b2411

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to