https://bugs.kde.org/show_bug.cgi?id=436413
--- Comment #18 from Paul Floyd <pjfl...@wanadoo.fr> ---
(In reply to Mark Wielaard from comment #15)
> ...checking header files and include directives
> *** File coregrind/m_replacemalloc/vg_replace_malloc.c must not include
> pub_tool_options.h
>
> Only core headers are allowed in non-tool source files.
>
> I assume this is for checking info.clo_realloc_zero_bytes_frees
> This seems to work, but I don't fully understand how.
> This is part of the vgpreload library, how does that have access to the
> tools variables?
It did strike me as being a bit out of place.
The global "clo" variables do get declared in both core and tool headers, but
not both (you can see this with
find . -name "*.h" -exec grep "VG_(clo_" {} /dev/null \; | grep extern
)
Which makes me think that ./include/pub_tool_replacemalloc.h is better.
Looking a bit more, it should be in
replacement_malloc_process_cmd_line_option
since this is an option that only applies to the tools that replace malloc (dh
drd hg ms mc).
I'll make the change tonight and update the patch.
--
You are receiving this mail because:
You are watching all bug changes.
