https://bugs.kde.org/show_bug.cgi?id=368956
Eike Hein <h...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |http://commits.kde.org/plas
| |ma-workspace/7dee461947ae2f
| |a6666cf7a6d0234fc92cabcc66
Status|CONFIRMED |RESOLVED
--- Comment #5 from Eike Hein <h...@kde.org> ---
Git commit 7dee461947ae2fa6666cf7a6d0234fc92cabcc66 by Eike Hein.
Committed on 19/09/2016 at 07:51.
Pushed by hein into branch 'Plasma/5.8'.
Treat NET::Utility type windows as SkipTaskbar.
Summary:
Utility windows (NET::Utility/_NET_WM_WINDOW_TYPE_UTILITY) should
not be on the Task Manager, but they should be on the Pager. This
patch achieves this by evaluating the window type in the
AbstractTasksModel::SkipTaskBar data role.
I considered the alternative approach of making a new
AbstractTasksModel::IsUtilityWindow (or similar) data role and
adding a pass to evaluate it to TaskFilterProxyModel, then
configuring the filter models in TasksModel and the Pager backend
differently. But this is not very extensible. Then I realized that
AbstractTasksModel data roles do not and should not reflect X11
idioms anyway; the point of the library is to abstract for the
purpose of UI, and what XWindowTasksModel considers "SkipTaskBar"
is really an implementation detail. This makes all the more sense
considering on Wayland we have no notion of window types (beyond
"popup") yet, and don't quite now how it's going to evolve.
Various API docstrings have been changed to better reflect that
the meaning of the data role doesn't map to anything specific in
the tasks.
Reviewers: #plasma, davidedmundson, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2807
M +2 -2 libtaskmanager/abstracttasksmodel.h
M +16 -16 libtaskmanager/taskfilterproxymodel.h
M +9 -1 libtaskmanager/xwindowtasksmodel.cpp
http://commits.kde.org/plasma-workspace/7dee461947ae2fa6666cf7a6d0234fc92cabcc66
--
You are receiving this mail because:
You are watching all bug changes.
