https://bugs.kde.org/show_bug.cgi?id=240854

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kwidgetsaddons/commi
                   |                            |t/29bb6db27efef72b3c9f20688
                   |                            |0bab79af38dc4cb
   Version Fixed In|                            |5.101

--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit 29bb6db27efef72b3c9f206880bab79af38dc4cb by Nate Graham.
Committed on 09/12/2022 at 21:16.
Pushed by ngraham into branch 'master'.

Make Full Screen action use consistent text and icon

This is a checkable action, and right now when unchecked, it shows "Full
Screen Mode" but when checked, it shows "Exit Full Screen Mode". The
icon changes too.

Changing the text when checked does not make sense and violates the HIG
(https://develop.kde.org/hig/components/editing/togglebutton/#behavior).
FIXED-IN: 5.101

M  +4    -19   src/ktogglefullscreenaction.cpp
M  +0    -3    src/ktogglefullscreenaction.h

https://invent.kde.org/frameworks/kwidgetsaddons/commit/29bb6db27efef72b3c9f206880bab79af38dc4cb

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to