https://bugs.kde.org/show_bug.cgi?id=461692
sh_zam <sh...@sdf.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|WAITINGFORINFO |FIXED
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/commit/2dfa0d19c
| |d176ef70c082c4970fc76e1b011
| |6900
--- Comment #6 from sh_zam <sh...@sdf.org> ---
Git commit 2dfa0d19cd176ef70c082c4970fc76e1b0116900 by Sharaf Zaman.
Committed on 18/11/2022 at 17:47.
Pushed by szaman into branch 'master'.
Bugfix: Vector shapes not swapping the current fg/bg color.
It is really difficult to see why this used to work before. But to get
to the reason for the bug, let's say we press the swap button on paintop
box. And the current active widget is "Fill" tab. So, the
KoFillConfigWidget (d->fillVariant = Fill) is activated. So, when we
swap the color, the color of Stroke is changed through the color of
Fill, but the d->colorAction's color is that of the fill, but since we
are swapping it for Stroke. The if (currentKoColor() == color) returns
true and this we skip swapping it for stroke.
We also fix the colorAction button for Stroke, it didn't work
properly (for the same reason, Fill changed the color back to what it
was when swapping).
(A TODO for future (which maybe somewhere near, given some things are
still buggy with this file), we really have to decouple Stroke and Fill
types).
M +4 -5 libs/ui/widgets/KoFillConfigWidget.cpp
https://invent.kde.org/graphics/krita/commit/2dfa0d19cd176ef70c082c4970fc76e1b0116900
--
You are receiving this mail because:
You are watching all bug changes.
