https://bugs.kde.org/show_bug.cgi?id=460504
Aleix Pol <aleix...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://invent.kde.org/plas | |ma/discover/commit/8577309c | |afbc9a07eff1cf7a5bdb25c0ac4 | |056b8 Version Fixed In| |5.26.1 Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #4 from Aleix Pol <aleix...@kde.org> --- Git commit 8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8 by Aleix Pol Gonzalez, on behalf of Nate Graham. Committed on 18/10/2022 at 00:46. Pushed by ngraham into branch 'master'. Reviews: Don't check for name field being empty when it's not visible Now, under certain circumstances, the name field will not be shown. But the logic for ensuring all review data has been filled out was not taking that into account, so it become impossible to submit a review when the field was invisible because technically it was empty, so it triggered the "Insert a name" condition. This commit fixes that by disabling the name check when the name field is invisible. FIXED-IN: 5.26.1 M +1 -1 discover/qml/ReviewDialog.qml https://invent.kde.org/plasma/discover/commit/8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8 -- You are receiving this mail because: You are watching all bug changes.