https://bugs.kde.org/show_bug.cgi?id=456511
Vlad Zahorodnii <vlad.zahorod...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/kwin/commit/b3214db0b7af
                   |                            |f89a82dbc4769f22c548f55863c
                   |                            |f
         Resolution|---                         |FIXED

--- Comment #30 from Vlad Zahorodnii <vlad.zahorod...@kde.org> ---
Git commit b3214db0b7aff89a82dbc4769f22c548f55863cf by Vlad Zahorodnii.
Committed on 05/10/2022 at 07:10.
Pushed by vladz into branch 'master'.

x11: Make damage region fetching code more robust to errors

With DamageReportNonEmpty damage report level, the x server will
send kwin a DamageNotify when the damage region changes from empty to
not empty.

The damage region will be made empty when SurfaceItemX11 calls
xcb_damage_subtract().

It appears like xcb_generate_id() can return us an already associated
XID, which eventually results in xcb_damage_subtract() failing and
breaking state tracking in SurfaceItemX11. KWin will no longer receive
DamageNotify events and some windows will freeze.

In order to make getting BadIdChoice less catastrophic, this change
makes the SurfaceItemX11 reset m_isDamaged after successfully fetching
the damage region. If xcb_generate_id() returns us a bad id, kwin will
try to fetch the damage again in the next frame.

M  +1    -1    src/surfaceitem_x11.cpp

https://invent.kde.org/plasma/kwin/commit/b3214db0b7aff89a82dbc4769f22c548f55863cf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to