https://bugs.kde.org/show_bug.cgi?id=368066
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/plas
| |ma-framework/8e517b1578ad1e
| |5988f440790f5048416a7dd68c
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 8e517b1578ad1e5988f440790f5048416a7dd68c by David Edmundson.
Committed on 03/09/2016 at 08:33.
Pushed by davidedmundson into branch 'master'.
WindowThumbnail: Do GL calls in the correct thread
WindowThumbnail did some open GL operations, discarding old textures, in
the GUI thread. Whislt it's not going to cause a threading issue (as
updatePaintNode always ran when the main thread was blocked) we're not
meant to mix threads with openGL contexts.
It also seems to have a GL leak on nvidia, which was previously masked
by the double delete fixed in
https://git.reviewboard.kde.org/r/126131/diff/2/
It seems only one worked, and in the applied version we went with the
wrong one.
This patch makes use of QQuickItem::releaseResources to delete the GL
textures on window change and destructor; it's then removed from
stopRedirecting so that start/stop redirecting handles xcb on the GUI
thread and updatePaintNode/discardPixmap is the GL stuff on the render
thread.
See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling
REVIEW: 128763
M +114 -44 src/declarativeimports/core/windowthumbnail.cpp
M +5 -1 src/declarativeimports/core/windowthumbnail.h
http://commits.kde.org/plasma-framework/8e517b1578ad1e5988f440790f5048416a7dd68c
--
You are receiving this mail because:
You are watching all bug changes.
