https://bugs.kde.org/show_bug.cgi?id=453149

Jean-Baptiste Mardelle <j...@kdenlive.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/kdenlive/commit/3f81
                   |                            |05070aeedcf09adba716f79639f
                   |                            |c63f72f96

--- Comment #4 from Jean-Baptiste Mardelle <j...@kdenlive.org> ---
Git commit 3f8105070aeedcf09adba716f79639fc63f72f96 by Jean-Baptiste Mardelle,
on behalf of Eric Jiang.
Committed on 25/07/2022 at 11:13.
Pushed by mardelle into branch 'master'.

Change vectorscope to use QImage::pixel()

Vectorscope tried to directly reinterpret the input QImage as RGB
data, which makes an assumption that the input is RGB. On Windows, the
input QImage is BGR, causing red and blue to be switched in the
Vectorscope.

QImage::pixel() checks QImageData->format and converts the to QRgb
appropriately. Casual benchmarking seems to show that using pixel() is
about 5% slower for each vectorscope calculation in the no-conversion
case (e.g. Linux).

M  +13   -12   src/scopes/colorscopes/vectorscopegenerator.cpp

https://invent.kde.org/multimedia/kdenlive/commit/3f8105070aeedcf09adba716f79639fc63f72f96

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to