https://bugs.kde.org/show_bug.cgi?id=453401
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/commit/21043b869
| |592df7f27cd3770964dd771a4cf
| |0ff2
--- Comment #7 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 21043b869592df7f27cd3770964dd771a4cf0ff2 by Dmitry Kazakov.
Committed on 19/07/2022 at 11:03.
Pushed by dkazakov into branch 'master'.
Fix a bug in brush speed calculation algorithm
KisSpeedSmoother used a rather naive implementation of the filtering
for the tablet event rate estimation. It just dropped the samples which
were too different from the current mean. It resulted in a weird bug:
when a lot of the tablet events were postponed by the blocked GUI-thread
(e.g. during image creation) the mean value fell into the cave of very
small values and couldn't be pulled out of it.
The patch implements a more clever approach using KisFilteredRollingMean
class. It keeps all the incoming values, but strips off the most extreme
values when calculating the mean.
The new algorithm is rather computation intensive, so we could think
about some lazy-computation solution for the future. But currently,
the whole computation takes about 7 microseconds, which is about 0.1%
of the GUI-thread's time for hight quality Wacom tablets.
M +1 -0 libs/global/CMakeLists.txt
A +90 -0 libs/global/KisFilteredRollingMean.cpp [License: GPL(v2.0+)]
A +75 -0 libs/global/KisFilteredRollingMean.h [License: GPL(v2.0+)]
M +15 -18 libs/ui/tool/kis_speed_smoother.cpp
https://invent.kde.org/graphics/krita/commit/21043b869592df7f27cd3770964dd771a4cf0ff2
--
You are receiving this mail because:
You are watching all bug changes.
