https://bugs.kde.org/show_bug.cgi?id=455570

stephen <tgdev...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REPORTED
         Resolution|FIXED                       |---

--- Comment #7 from stephen <tgdev...@gmail.com> ---
(In reply to Dmitry Kazakov from comment #5)
> Git commit bef36adac9ed3934c68431da838045041fa4a31d by Dmitry Kazakov.
> Committed on 22/06/2022 at 12:48.
> Pushed by dkazakov into branch 'krita/5.1'.
> 
> Fix a slowdown when Shift+gestrure-resize huge and complex brushes
> 
> This patch does two things:
> 
> 1) Now the brush outline is generated **not** from the real brush tip,
>    generated by generateMaskAndApplyMaskOrCreateDab(), but from the
>    original brushTipImage(). It should generate the same outline, unless
>    any of our brush modes support changing opacity of the brush tip
>    (afaict, none of them support that).
> 
> 2) The outline and pyramid caches are now shared between the source and
>    cloned brush tips. That is, updating a cache inside a cloned brush will
>    also update the cache inside the source brush (in the registry). This
>    decision is a bit scary, but solves really a lot of performance troubles.
>    The link between the two brush objects will be reset only when one of
>    the objects calls `cache.reset()`.
> 
> M  +19   -20   libs/brush/kis_brush.cpp
> M  +139  -16   libs/global/KisLazySharedCacheStorage.h
> 
> https://invent.kde.org/graphics/krita/commit/
> bef36adac9ed3934c68431da838045041fa4a31d

Greetings. 
Also I want to say that the issue is not really fixed.
Because the problem remains  when the brush size is
very complex or around 1700 px.
But there's this brush from the moo ink bundle, called the "moo bubble".
I swear that even right now, only at 150 px, it stutters a freaking lot. 
Because of this, I'll say that there's been an improvement but it's not really
fixed completely yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to