https://bugs.kde.org/show_bug.cgi?id=434317

Daniel Vrátil <dvra...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-firewall/commit/8
                   |                            |67e5824387344f0795382b17dcf
                   |                            |37ab1b5f5cdc
         Resolution|---                         |FIXED

--- Comment #3 from Daniel Vrátil <dvra...@kde.org> ---
Git commit 867e5824387344f0795382b17dcf37ab1b5f5cdc by Daniel Vrátil.
Committed on 20/06/2022 at 14:48.
Pushed by dvratil into branch 'feature/ip-netmask'.

Allow IP addresses with netmask in advanced rule editor

Especially for firewall configuration, it's very much useful to be
able to allow or block subnets (e.g. I want to allow all traffic
originating on trusted part of my home network). Both UFW and
firewalld to accept IP addresses with netmask, so it is just about
allowing them in the input's validtors.

I decided to replace the regular expressions with a custom QValidator
subclass, which uses lib'c inet_pton() to validate the entered IP
address and can also handle optional netmasks.
CHANGELOG: Allow IP addresses with netmask in advanced rule editor

M  +2    -0    CMakeLists.txt
A  +3    -0    autotests/CMakeLists.txt
A  +72   -0    autotests/ipvalidatortest.cpp     [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
M  +2    -0    kcm/core/CMakeLists.txt
A  +102  -0    kcm/core/ipvalidator.cpp     [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
A  +31   -0    kcm/core/ipvalidator.h     [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
M  +2    -0    kcm/kcm.cpp
M  +3    -7    kcm/package/contents/ui/IpTextField.qml

https://invent.kde.org/plasma/plasma-firewall/commit/867e5824387344f0795382b17dcf37ab1b5f5cdc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to